Feat/async git improvements#20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 What
Replaces
promisify(execFile)across the service layer with a spawn-basedrunClihelper that does cross-platform process-group kills, captures stderr into errors, and forces non-interactive env for git/gh. Adds three injector-resolvedSemaphorepools (GitOperationLimit/InstallOperationLimit/BuildOperationLimit, defaults 10 / 3 / 1) so a long build never blocks a quickgit fetch. Consolidates two ad-hocgit ls-remote --exit-codecallers behindGitService.lsRemote.🐛 Why
execFile'stimeoutonly SIGTERMs the parent — grandchildren (credential helpers, ssh,git-remote-https, GUI askpass) kept the inherited stdio pipes open, so the promise could stay pending for ~60 s past the nominal timeout with a bareCommand failed: …\nand no stderr (nodejs/node#2098). Same shape blockedgh auth statuswhen a stale token tried to open an interactive browser flow.✅ Tests
run-cli.spec.ts,operation-limits.spec.ts,git-service-runner.spec.ts(env hardening, timeout/kill,GitOperationLimitqueueing).one-shot-command-runner.spec.ts(install/build pool serialization + cross-pool independence),validate-repo-action.spec.ts,check-prerequisite-action.spec.ts(migrated mocks).